Skip to content

telemetry(smus): Add result when emitting show prompt metric#8618

Merged
laileni-aws merged 2 commits intoaws:masterfrom
ziwikiwi:add-result-to-emitted-metric
Feb 26, 2026
Merged

telemetry(smus): Add result when emitting show prompt metric#8618
laileni-aws merged 2 commits intoaws:masterfrom
ziwikiwi:add-result-to-emitted-metric

Conversation

@ziwikiwi
Copy link
Contributor

Problem

Did not include "Result: Success" in the emitted metric for showing the AGENTS.md prompt, which resulted in a warning when logging the metric.

Solution

Added this missing field.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ziwikiwi ziwikiwi requested a review from a team as a code owner February 25, 2026 23:22
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@laileni-aws laileni-aws merged commit 608b890 into aws:master Feb 26, 2026
14 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants