fix(sagemaker): Remove top-level sagemaker-ssh-kiro VSIX#8624
Open
dylanraws wants to merge 1 commit intoaws:masterfrom
Open
fix(sagemaker): Remove top-level sagemaker-ssh-kiro VSIX#8624dylanraws wants to merge 1 commit intoaws:masterfrom
dylanraws wants to merge 1 commit intoaws:masterfrom
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
laileni-aws
approved these changes
Feb 27, 2026
ziwikiwi
approved these changes
Feb 27, 2026
aseemxs
approved these changes
Feb 27, 2026
ashishrp-aws
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sagemaker-ssh-kiroextension being present even though it's not needed theresagemaker-ssh-kiroextension version is updated (e.g., 0.2.0 -> 0.3.0), there can be two VSIX files in the toolkit resources directory, which can eventually lead to an error as the toolkit cannot determine which file to install at runtimeSolution
toolkit, move (rather than copy) thesagemaker-ssh-kiroVSIX file to the toolkit resources directory, so that it will be no longer present at the top level, thus preventing any CI build failuressagemaker-ssh-kiroVSIX files from the toolkit resources directory before moving the new file therefeature/xbranches will not be squash-merged at release time.