Skip to content

fix(sagemaker): Remove top-level sagemaker-ssh-kiro VSIX#8624

Open
dylanraws wants to merge 1 commit intoaws:masterfrom
dylanraws:fix/remove-top-level-sagemaker-ssh-kiro-vsix
Open

fix(sagemaker): Remove top-level sagemaker-ssh-kiro VSIX#8624
dylanraws wants to merge 1 commit intoaws:masterfrom
dylanraws:fix/remove-top-level-sagemaker-ssh-kiro-vsix

Conversation

@dylanraws
Copy link
Contributor

Problem

  1. Toolkit CI builds fail when they detect more than one VSIX file at the top level, due to the sagemaker-ssh-kiro extension being present even though it's not needed there
  2. Whenever the sagemaker-ssh-kiro extension version is updated (e.g., 0.2.0 -> 0.3.0), there can be two VSIX files in the toolkit resources directory, which can eventually lead to an error as the toolkit cannot determine which file to install at runtime

Solution

  1. As part of packaging toolkit, move (rather than copy) the sagemaker-ssh-kiro VSIX file to the toolkit resources directory, so that it will be no longer present at the top level, thus preventing any CI build failures
  2. Remove all sagemaker-ssh-kiro VSIX files from the toolkit resources directory before moving the new file there

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dylanraws dylanraws requested a review from a team as a code owner February 26, 2026 23:52
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants