Merged
Conversation
- Fix OAuth2 parameter name in identity module - Improve JSON serialization consistency - Fix memory client region detection - Fix JSON response double wrapping issue
guoken1
reviewed
Jul 23, 2025
| # When region_name is provided, environment variable should still take precedence | ||
| client1 = MemoryClient(region_name="us-west-2") | ||
| assert client1.region_name == "us-east-1" # Environment wins over explicit param | ||
| assert client1.region_name == "us-west-2" # Environment wins over explicit param |
Contributor
There was a problem hiding this comment.
the comment should be updated
Contributor
Author
There was a problem hiding this comment.
thanks for the catch.
guoken1
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.