Open
Conversation
Contributor
Author
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage ? 88.70%
=======================================
Files ? 20
Lines ? 1859
Branches ? 278
=======================================
Hits ? 1649
Misses ? 104
Partials ? 106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This pull request updates the initialization logic for the
AgentCoreMemorySessionManagerto support setting the AWS region from theAWS_REGIONenvironment variable, and adds a corresponding unit test to ensure this behavior works as expected.Configuration improvements:
__init__method insession_manager.pyto setregion_namefrom theAWS_REGIONenvironment variable if it is present, improving flexibility for deployment environments.Testing enhancements:
test_init_with_aws_region_env_varintest_agentcore_memory_session_manager.pyto verify that the session manager correctly uses theAWS_REGIONenvironment variable during initialization.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.