feat: Add operation and type registry codegen#2113
Open
feat: Add operation and type registry codegen#2113
Conversation
jbelkins
commented
Feb 26, 2026
| "rootProject": true | ||
| }, | ||
| "mergeModels": false, | ||
| "mergeModels": true, |
Contributor
Author
There was a problem hiding this comment.
Models for protocol tests will be merged into a single Models.swift file.
This provides faster performance on the larger protocol test suites.
jbelkins
commented
Feb 26, 2026
| // we always need to have an InputBodyMiddleware | ||
| operationMiddleware.removeMiddleware(operation, "OperationInputBodyMiddleware") | ||
| operationMiddleware.appendMiddleware(operation, OperationInputBodyMiddleware(ctx.model, ctx.symbolProvider, true)) | ||
| operationMiddleware.appendMiddleware(operation, OperationInputBodyMiddleware(ctx, true)) |
Contributor
Author
There was a problem hiding this comment.
This middleware's interface was simplified in the companion smithy-swift PR.
jbelkins
commented
Feb 26, 2026
| @@ -0,0 +1,12 @@ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
Here & below, you can see the new swift-settings.json file that is replacing smithy-model-info.json.
swift-settings.json is committed here only for the internal services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is a companion to smithy-lang/smithy-swift#1033. I recommend reviewing that PR before this one.
Changes:
swift-settings.jsonfile for internal clients.New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.