feat(aws-lambda-polly): new construct #1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgebearden
approved these changes
Feb 9, 2026
Contributor
georgebearden
left a comment
georgebearden
left a comment
There was a problem hiding this comment.
Looks great - just a a couple questions/suggestions on property names.
| * | ||
| * @default - false | ||
| */ | ||
| readonly asyncJobs?: boolean; |
Contributor
There was a problem hiding this comment.
is asyncJobs a clear property name? I haven't looked at the underlying API/docs for this, so it may already be using the same nomenclature.
Contributor
Author
There was a problem hiding this comment.
For better or worse, it's a name standardized in existing Construct interfaces
| * | ||
| * @default - true | ||
| */ | ||
| readonly logS3AccessLogs?: boolean; |
Contributor
Author
There was a problem hiding this comment.
For better or worse, it's a name standardized in existing Construct interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.