Logmsg shrink payload when queued #927
Open
+139
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
This functionality is going to be refactored into a more elaborate algorithm to resize an NVTable, assuming a new storage needed. To be used both from nv_table_clone() and nv_table_resize(), in a next patch. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Whenever NVTable needs to grow (either during clone or realloc), the new nv_table_get_next_size() function calculates the right new size, while ensuring some "additional_space" becomes available in the new clone. Previously, we always erred on the side of increasing the allocation size, so that any expected new changes would not need another bump of the size. This algorithm however, can waste a lot of memory. The new algorithm is: * increase at least 256 bytes, * only increase the size if the current allocation does not fit * use 4k aligned sizes for large NVTables (>4kB) or 1k for small ones We might have slightly more reallocs this way, but the total allocation of a LogMessage should be a lot less. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…e_realloc() Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…() function We do not support cases where these would point to different instances, so reduce redundancy by using a single in/out pointer. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
In case our "payload" would be larger than 2kB, do not piggy back the payload at the end of the LogMessage. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…the queue Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
logmsg-shrink-payload-when-queued
branch
from
cc9945c to
9ffbf97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #889 and #891 containing the message shrinking part. Only to be considered when those other two are merged.