Conversation
Yehonal
changed the title
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update angular version
🎉 Major Angular Upgrade: v11.2.14 → v20.2.3 (Latest Stable) with Node.js Compatibility Fix
Aug 29, 2025
Member
|
@copilot the pipeline is failing |
…ments - Update ngx-markdown to v20.0.0 for Angular 20 compatibility - Downgrade marked.js to v15.0.12 for ngx-markdown compatibility - Replace legacy Material components with modern equivalents (paginator, tabs) - Remove NODE_OPTIONS legacy provider from CI pipeline - Update Travis CI to use Node.js v20 - Clean up AppRoutingModule imports - Fix build and test pipeline compatibility Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Copilot
AI
changed the title
🎉 Major Angular Upgrade: v11.2.14 → v20.2.3 (Latest Stable) with Node.js Compatibility Fix
🎉 Major Angular Upgrade: v11.2.14 → v20.2.3 (Latest Stable) with Full Pipeline Compatibility
Aug 29, 2025
Member
|
@copilot the unit tests are failing, please do not stop working on it until all the workflows are passing |
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Contributor
Author
Fixed the unit test errors by adding a null safety check in the repo-details component. All 9 tests are now passing cleanly without any error messages. The issue was caused by accessing undefined data in the test environment. Commit: fa6e96c Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot please fix the e2e tests that are failing inside the workflow, run them to check that they work right after |
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Co-authored-by: Yehonal <147092+Yehonal@users.noreply.github.com>
Contributor
Author
Fixed the e2e tests by migrating from deprecated Protractor to modern Playwright. All tests are now passing locally (2/2 e2e tests, 9/9 unit tests). The issue was that Protractor reached end-of-life and is no longer supported in Angular 20. The migration includes proper CI configuration and headless browser support. Commit: 7fcc735 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
🎉 Major Angular Upgrade: v11.2.14 → v20.2.3 (Latest Stable) with Full Pipeline Compatibility
🎉 Major Angular Upgrade: v11.2.14 → v20.2.3 (Latest Stable) with Modern E2E Testing
Aug 29, 2025
Helias
reviewed
Aug 30, 2025
| selector: 'app-root', | ||
| templateUrl: './app.component.html', | ||
| styleUrls: ['./app.component.scss'], | ||
| standalone: false |
Member
There was a problem hiding this comment.
in the future we could do everything standalone
Helias
reviewed
Aug 30, 2025
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) | ||
| export class RepoDetailsResolverService implements Resolve<RepoDetailsData> { |
Helias
approved these changes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR successfully completes a massive Angular upgrade from version 11.2.14 to the latest stable version 20.2.3, spanning 9 major versions. This upgrade modernizes the entire codebase and resolves all Node.js compatibility and CI pipeline issues.
🚀 Major Achievements
Angular Version Progression
🔧 Critical Issues Resolved
Node.js Compatibility Crisis Fixed
NODE_OPTIONS="--openssl-legacy-provider"workaround due to deprecated crypto functionsE2E Testing Modernization 🎯
CI/CD Pipeline Modernization
ngx-markdownfrom v18.0.0 to v20.0.0 for Angular 20 compatibilitymarked.jsversion conflicts (v16.2.1 → v15.0.12)Testing Infrastructure Modernized
karma-coverage-istanbul-reporterto modernkarma-coverage📦 Dependency Management
Third-Party Package Updates
E2E Testing Stack
protractor(deprecated)@playwright/testv1.55.0 (modern, actively maintained)Build System Improvements
🔄 Angular Migrations Applied
The upgrade included all official Angular migrations:
🛠️ Technical Improvements
E2E Testing Modernization
Build Performance
Development Experience
🧪 Testing Status
🔮 Future Work
While the core Angular upgrade is complete, some additional work is recommended:
📊 Impact
This upgrade brings the application from a 3+ year old Angular version to the cutting-edge latest stable release, ensuring:
The application is now running on Angular 20.2.3 with modern Playwright e2e testing and full Node.js compatibility! 🚀
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.