Assorted consistency tweaks

[XhmikosR]

@azlux let me know what you think :)

Non-whitespace diff: https://github.com/azlux/log2ram/pull/258/files?w=1

[azlux]

Hi,
You are doing multiple changes in the same time.
Into you change, you switch [ with [[, they are not the same, and not really posix compatible.

Into your PR, please, don't send your .vscode/ files.

Replacing sourceby .is indeed a best-practice. We should keep that. Same for the bash ShellCheckyou have done.

[XhmikosR]

I know the differences of [[. But you are already using [[ in some places and the shebang already points to bash, not sh. Am I missing something?

I will drop the VSCode changes and rebase later.

[XhmikosR]

@azlux I dropped the VS Code patch.

As for POSIX compatibility, you already use bash specific stuff like set -euo pipefail, HOSTNAME, arrays and echo -e. You can check with shellcheck which helps catch these errors and using sh in the shebang.

I just went with what you have specified in the shebang. If the scripts are supposed to run under sh, the shebang should reflect it and then I can update my changes or drop it altogether.

[azlux]

Hi,
You're right. I didn't run shellcheck since a while, and havn't notice I have introduce bash specific code in my own code.

[XhmikosR]

I have made sure shellcheck passes in this branch so far. We could go with sh compatibility later but IMHO it's not worth it for now.

The changes should be OK, but another pair of eyes would be good to have a look at :)

[git-staus]

Not sure if I am just adding noise or not, but it might help finding reviewers if each conceptually identical change had its own separate commit, preferrably with both a title and an body explaining the rationale. I personally follow these guidelines to a fault.