feat(setup): rewrite /claude-code-setup to 3-phase flow#48
Merged
Conversation
91ea703 to
9ebaef7
Compare
a2cfea8 to
8925dc8
Compare
Reduce permission prompts from ~12-18 to 2 for any scenario. - Add lib/setup-status.sh discovery script (JSON output) - Add --remove-skill and --remove-mcp flags to install.sh - Rewrite commands/claude-code-setup.md to 3-phase flow - Update website docs for new command and module management - Add test scenarios 26 (setup-status) and 27 (remove flags) Record 040
8925dc8 to
2e5e445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/setup-status.shdiscovery script that outputs JSON status in a single call--remove-skilland--remove-mcpflags toinstall.shfor non-interactive removalcommands/claude-code-setup.mdto 3-phase flow (discover → present → execute)Problem
/claude-code-setuptriggered ~12-18 permission prompts during discovery (curl, git clone, ls, jq reads, etc.). Users clicked through a wall of approvals for read-only operations before anything useful happened.Solution
Three changes that reduce any scenario to 2 permission prompts:
lib/setup-status.sh) — replaces 8-12 individual Bash calls with one script that outputs JSON--remove-skill,--remove-mcp) — enables chaining removals without interactive promptsTest plan
./tests/test.sh 26— setup-status.sh (31 assertions)./tests/test.sh 27— remove flags (20 assertions)./tests/test.sh 09— claude-code-setup command (42 assertions)./tests/test.sh/do-reviewpassedFiles Changed
lib/setup-status.sh(new)install.shcommands/claude-code-setup.mdtests/scenarios/26-setup-status.sh(new)tests/scenarios/27-remove-direct.sh(new)docs/records/040-setup-command-ux.md(new)website/pages/commands/claude-code-setup.mdxwebsite/pages/features/module-management.mdxCLAUDE.mdCHANGELOG.md