Closed
Conversation
Author
|
This unlocks usage of #932 |
4 tasks
pastelsky
force-pushed
the
sk/deprecate-old-node
branch
from
5de0c65 to
7aeb25d
Compare
|
Files changed. |
JLHwung
reviewed
Mar 22, 2022
| }, | ||
| "dependencies": { | ||
| "find-cache-dir": "^3.3.1", | ||
| "lmdb": "^2.2.4", |
Contributor
There was a problem hiding this comment.
The package.json changes are part of #932, can you revert them and update the lockfile accordingly for this PR?
JLHwung
reviewed
Mar 22, 2022
| "loose": true, | ||
| "targets": { | ||
| "node": "6.9" | ||
| "node": "12.0.0" |
Contributor
There was a problem hiding this comment.
nit: Let's bump to 12.17.0, the first node 12 version with ESM unflagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Node versions as low as v10 are supported and babel-loader's source code is transpiled heavily to suit older node versions.
What is the new behavior?
Upgrades minimum node version requirement to v12. v12 itself is in maintenance mode and due to be outdated soon — it doesn't make a lot of sense to keep supporting node 10 or below.
Additionally, I've upgraded yarn and regenerated yarn.lock too.
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...