-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Feature] Add filtering to Who's Using page #1826 #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Deploy preview for babel ready! Built with commit 5468d84 |
|
Another update. I did some work on the styling, and made all filter options work. Especially legacy added users (without any details) look nice now as well. Re my question above:
|
|
This looks awesome. We will somehow port this for default users page for Docusaurus 2. @amyrlam I think this is great https://deploy-preview-1834--babel.netlify.com/en/users |
|
Based on the Slack #website channel feedback: Remove attributes (by @existentialism / @hzoo)
Add attributes (by @hzoo)
Keep attributes
Also @endiliey would be happy to help with porting. [wip] |
|
@ymschaap in regards to the mockup form:
I think this all looks pretty pretty nice! I had a few UX suggestions to tighten up your mockup form. I'm not sure what the limitations are, but I noticed that you don't have any required fields either. Perhaps a few for some of the most basic information you want to capture. |
|
@jannaee fixed it: |
|
Hey nice @ymschaap and I like the notifications pop up bar too! |
|
Nice, thanks for the review as well @jannaee! In terms of info: Company using it is great but yeah I don't know how much information we want until it gets to cluttered (at least on the website): maybe just testimonial, link to site/usage, and if they are supporting us in some way. Aside: I would like to know a few things (it doesn't have to be reflected on the page): how you use it (for what reason, what plugins), do they use any 3rd party plugins, do they have their own custom plugins, have they written any posts/talks/docs about Babel or using it (would they like to contribute that back), and are they willing to sponsor the project (did you know it was all volunteers), or are their people at the company willing to get involved more, or would they like to have paid support/consulting/workshops/talk. Maybe it should be a follow up, or we should ask if they want to video chat. |
|
@hzoo did you see my latest commits: preview It is what you describe (testimonial only, no clutter view). The things in your I've now build the features and views as proposed and discussed. Let me know what else to do to finish this up. |
|
I've removed test data from the migrated dataset (which had some fake testimonials and flags).
|
|
Testimonials: yeah I suppose but it would probably take time to get responses, but we could reach out to people. sponsors: are just those on https://babeljs.io yeah contributors? don't really have regular ones at the moment: although recently bloomberg (https://babeljs.io/blog/2018/09/17/7.1.0#private-static-fields-stage-3), and also @jridgewell who works on AMP/Google so I would consider that sponsored work. I guess that section is different because it's going to be for a certain time. Like Adobe/Behance sponsored my time there while I worked there. And Facebook sponsored time previously but not at the moment (Sebastian for Babel 6, Amjad/Juriy for minify). |
|
Tagged Behance as sponsor. Adobe, Google aren't listed yet in the (migrated) users list. And Facebook is tagged as sponsor/contributor. I think what we have now is an improvement of the existing Users list. And expect testimonials to come in over time. Now up to the maintainers to decide on to merge or not 👍 |
|
This #1834 PR is stuck for a while now. Please lets decide on supporting to merge it or not (and move on). |
Change Facebook wordmark to a svg logo As a test. Support for all header filter and sort options And lots of layout fine tuning to support a nice legacy layout. Move to a testimonial like list Fix calculation of row Filter renamed Paypal to icon Added company Teampage to users Added logo Teampage Added add-your-company bot It works. See #10 Added a far away default timestamp Which fixes sort by Newest Removed test user data. Added matching flags. Added (previous) sponsor Behance Re: babel#1834 (comment) My bad





Re: #1826
To keep momentum, I did some work on my own feature proposal #1826. This is a work in progress, but it works. Live branch.
Design
I tried to match the design in the mockup. Big difference is that most existing logo's are logo's including wordmarks, hence having the Mozilla logo and the name Mozilla underneath is double. Vice versa: having an unknown logo, with no name is also confusing. I'll find a solution.
Also needs some more work in the details.
Code
No React or Less/Sass on the frontend, so wrote vanilla JS code. I embedded the user data as a JSON object in the html.
Data
Also migrated the HAML data format to a JS format, which is both readable, while native to the environment (read Node + React).
I added some mockup attribute values for a set of companies.
Questions
Other features like lazy load images can easily be added. But don't want to make this to big right now.