fix: handle pages without aliases to prevent infinite loops#146
Open
marmionl wants to merge 1 commit intobackstage:masterfrom
Open
fix: handle pages without aliases to prevent infinite loops#146marmionl wants to merge 1 commit intobackstage:masterfrom
marmionl wants to merge 1 commit intobackstage:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cam across this bug when attempting to generate a component that used the sample docs in this repository on my local version of Backstage and it gave the following error:
I have changed the loop condition in the
__get_page_dir_aliasto safely exit when no more path segments remain to check. This allows the method to gracefully returnNonefor pages without aliases instead of crashing.