Conversation
…re/pod-embedded into hvIOX_refactor
…mbedded into hvIOX_refactor
EUdds
left a comment
EUdds
left a comment
There was a problem hiding this comment.
Overall great work! There are a few things I mentioned in the comments that you should touch up on. Otherwise, we'll wait to merge this with main until we get some hardware and can test the code more completely.
| @@ -0,0 +1,69 @@ | |||
| // Author: Marco | |||
There was a problem hiding this comment.
Perhaps add some comments to these tests so that someone who doesn't know what the functions are can tell what exactly is failing/passing
embedded/peripherals/src/hv_iox.cpp
Outdated
| if (this->setupIox() != 0) | ||
| isInit = false; | ||
| } | ||
| if (isInit) |
There was a problem hiding this comment.
An if/else statement here would be less confusing
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
this file generates a compile_commands.json file for the ccls language server. I use this for syntax checking and autocomplete. It also generates other crap I don't need which is the point of the git clean command. I also will run this command as a lazy way to fix build issues if there are untracked files messing up compilation.
2 participants
Description
converted the hv_iox.c file to cpp and update references accordingly
Type of change
refactoring to cpp
Problem
There are still warnings that were outside the scope of this feature