Set SCI_CLOCKF as per data sheet, add defines for clock parameters#107
Open
episource wants to merge 3 commits intobaldram:masterfrom
Open
Set SCI_CLOCKF as per data sheet, add defines for clock parameters#107episource wants to merge 3 commits intobaldram:masterfrom
episource wants to merge 3 commits intobaldram:masterfrom
Conversation
Section 4.2: SCI_CLOCKF=0x8800 (SC_MULT=3.5, SC_ADD=1.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the SCI_CLOCKF register configuration to match the data sheet recommendations (section 4.2, SCI_CLOCKF=0x8800).
Also defines for associated clock parameters (SCI_CLOCKF, SLOW_SCK, FAST_SCK) are added.
Effect on VS1053B operation of this PR: The CLKI frequency of VS1053B will be increased by 0.5xXTALI. This means slightly faster operation, faster SPI, but potentially more power consumption.
This is a backwards compatible change. No need to change sketches using this library.