Add support for match statements where pattern is const#167
Draft
heshanpadmasiri wants to merge 12 commits intoballerina-platform:mainfrom
Draft
Add support for match statements where pattern is const#167heshanpadmasiri wants to merge 12 commits intoballerina-platform:mainfrom
heshanpadmasiri wants to merge 12 commits intoballerina-platform:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
We can narrow the types of each function concurrently
This is a pre-requsit for moving type resolution to type narrowing
Unless actual type resolution of an expression depends on the context (struct constructors) they should all be resolved in the type resolver
Fix exhaustiveness checks
235b815 to
f843c7d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 27.90% 29.12% +1.21%
==========================================
Files 254 257 +3
Lines 53858 54627 +769
==========================================
+ Hits 15031 15909 +878
+ Misses 37890 37758 -132
- Partials 937 960 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
resolves #98
depends on #150, #182