Skip to content

Remove parameters from the graphql diagram references#252

Merged
NipunaRanasinghe merged 7 commits intoballerina-platform:mainfrom
samithkavishke:issue-1037
Sep 1, 2025
Merged

Remove parameters from the graphql diagram references#252
NipunaRanasinghe merged 7 commits intoballerina-platform:mainfrom
samithkavishke:issue-1037

Conversation

@samithkavishke
Copy link
Contributor

@samithkavishke samithkavishke commented Aug 27, 2025

Purpose

This PR fix the #1037

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@samithkavishke samithkavishke marked this pull request as ready for review August 28, 2025 04:24
@samithkavishke samithkavishke marked this pull request as draft August 28, 2025 04:26
@samithkavishke samithkavishke marked this pull request as ready for review August 28, 2025 04:28
@dulajdilshan
Copy link
Contributor

@samithkavishke Let's add some tests covering the following cases

  • Methods in a GraphQL service class has parameters with reference types of imported and local types
  • Methods in Class type has parameters with reference type - This would test the skipParameters = false case

@dulajdilshan
Copy link
Contributor

@samithkavishke There are some checkstyle issues. Shall we resolve them?

@pasindufernando1
Copy link
Contributor

@samithkavishke The fix for the build failure is now merged. You can sync it to resolve the failures

Copy link
Contributor

@pasindufernando1 pasindufernando1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dulajdilshan dulajdilshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NipunaRanasinghe NipunaRanasinghe merged commit ac03dd6 into ballerina-platform:main Sep 1, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants