Skip to content

Fix issue with rendering included record params as named args#268

Merged
LakshanWeerasinghe merged 2 commits intoballerina-platform:mainfrom
LakshanWeerasinghe:fix#1065
Sep 1, 2025
Merged

Fix issue with rendering included record params as named args#268
LakshanWeerasinghe merged 2 commits intoballerina-platform:mainfrom
LakshanWeerasinghe:fix#1065

Conversation

@LakshanWeerasinghe
Copy link
Contributor

Purpose

$subject

Fixes wso2/product-ballerina-integrator#1065

Screen.Recording.2025-09-01.at.10.35.46.mov

@LakshanWeerasinghe LakshanWeerasinghe requested review from Copilot and removed request for KavinduZoysa September 1, 2025 05:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with rendering included record parameters as named arguments in the flow model generator. The fix ensures that when included record parameters are passed as named arguments, they are properly handled and remaining parameters are not incorrectly added to the property map.

  • Added test case with HTTP client initialization using named arguments for included record parameters
  • Modified parameter processing logic to track when included parameters are used as named arguments
  • Fixed parameter removal timing to occur after processing all argument types

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
new_connection.bal Added test case for HTTP client with named arguments including config parameter
new_connection1.json Added expected JSON output for the new test case
new_connection2.json Added expected JSON output for the new test case
new_connection3.json Added expected JSON output for the new test case
CodeAnalyzer.java Fixed parameter processing logic to handle included record parameters as named arguments correctly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@LakshanWeerasinghe LakshanWeerasinghe merged commit 74cfd62 into ballerina-platform:main Sep 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flow diagrams keeps on loading

3 participants