Fix issue with rendering included record params as named args#268
Merged
LakshanWeerasinghe merged 2 commits intoballerina-platform:mainfrom Sep 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with rendering included record parameters as named arguments in the flow model generator. The fix ensures that when included record parameters are passed as named arguments, they are properly handled and remaining parameters are not incorrectly added to the property map.
- Added test case with HTTP client initialization using named arguments for included record parameters
- Modified parameter processing logic to track when included parameters are used as named arguments
- Fixed parameter removal timing to occur after processing all argument types
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| new_connection.bal | Added test case for HTTP client with named arguments including config parameter |
| new_connection1.json | Added expected JSON output for the new test case |
| new_connection2.json | Added expected JSON output for the new test case |
| new_connection3.json | Added expected JSON output for the new test case |
| CodeAnalyzer.java | Fixed parameter processing logic to handle included record parameters as named arguments correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
xlight05
approved these changes
Sep 1, 2025
e0aa147 to
4d54615
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Fixes wso2/product-ballerina-integrator#1065
Screen.Recording.2025-09-01.at.10.35.46.mov