Include data_mappings.bal in deciding the function range of functions found in mappings#272
Merged
KavinduZoysa merged 8 commits intoballerina-platform:mainfrom Sep 1, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the data mapping functionality to include data_mappings.bal file when determining function ranges for functions found in mappings, addressing issue #991.
- Adds support for searching functions in both
functions.balanddata_mappings.balfiles - Refactors function range detection logic to check multiple documents
- Updates all mapping generation methods to pass the additional document parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DataMapperService.java | Loads data_mappings.bal document and passes it to the mapping generation |
| DataMapManager.java | Updates all mapping methods to accept and utilize the additional data mapping document for function range detection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java
Show resolved
Hide resolved
...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java
Outdated
Show resolved
Hide resolved
KavinduZoysa
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses : wso2/product-ballerina-integrator#991