[1.2.X] Fix the issue with generating http service using OpenAPI spec#280
Merged
NipunaRanasinghe merged 3 commits intoballerina-platform:1.2.xfrom Sep 5, 2025
Merged
Conversation
7b9bbdd to
b9850ab
Compare
...r-ls-extension/src/test/resources/add_service/config/add_http_service_from_openapi_spec.json
Show resolved
Hide resolved
...vice-model-generator-ls-extension/src/test/resources/add_service/source/sample1/openapi.yaml
Outdated
Show resolved
Hide resolved
b9850ab to
cabcfd6
Compare
cabcfd6 to
1b05187
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with generating HTTP services using OpenAPI specifications. The fix ensures the design approach is properly populated before determining whether to use OpenAPI-based or regular service generation.
- Adds call to
populateDesignApproach()to properly initialize service configuration - Includes test resources and test case for OpenAPI spec-based service generation
- Adds validation to verify the fix works correctly with OpenAPI specifications
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
openapi.yaml |
Test OpenAPI specification with albums API endpoints and schema definitions |
add_http_service_from_openapi_spec.json |
Test configuration for validating OpenAPI-based service generation |
AddServiceTest.java |
Adds test method and skips list for OpenAPI spec validation |
HttpServiceBuilder.java |
Core fix - adds populateDesignApproach() call before OpenAPI processing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...r-ls-extension/src/test/resources/add_service/config/add_http_service_from_openapi_spec.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
NipunaRanasinghe
approved these changes
Sep 5, 2025
44eb185
into
ballerina-platform:1.2.x
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Fixes wso2/product-ballerina-integrator#1146
Screen.Recording.2025-09-04.at.15.27.01.mov