[1.2.X] Fix with displaying param with map<anydata> subtypes as Payload params#282
Merged
NipunaRanasinghe merged 3 commits intoballerina-platform:1.2.xfrom Sep 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the display of parameters with map<anydata> subtypes as Payload parameters in the service model generator. The changes ensure that parameters that are subtypes of map<anydata> are correctly categorized as PAYLOAD parameters instead of QUERY parameters.
- Added logic to detect
map<anydata>subtypes and classify them as payload parameters - Updated test resources to include a new
DateInforecord type and parameter - Added constant for HTTP_PARAM_TYPE_PAYLOAD
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main.bal | Added DateInfo parameter to anonReturn function and DateInfo record type definition |
| get_http_resource_model_6.json | Added test configuration for dateInfo parameter with PAYLOAD type |
| Constants.java | Added HTTP_PARAM_TYPE_PAYLOAD constant |
| HttpFunctionBuilder.java | Implemented logic to detect map subtypes and set them as payload parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../java/io/ballerina/servicemodelgenerator/extension/builder/function/HttpFunctionBuilder.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Fixes wso2/product-ballerina-integrator#1140