Fix the concurrent issue in the publish artifacts API#290
Merged
nipunayf merged 1 commit intoballerina-platform:1.2.xfrom Sep 8, 2025
Merged
Fix the concurrent issue in the publish artifacts API#290nipunayf merged 1 commit intoballerina-platform:1.2.xfrom
nipunayf merged 1 commit intoballerina-platform:1.2.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a concurrency issue in the publish artifacts API where the artifacts() method was throwing an ArrayIndexOutOfBoundsException during sorting operations. The fix replaces HashMap with TreeMap for automatic sorting and removes the manual sorting logic that was causing thread safety issues.
- Replaces HashMap with TreeMap for automatic sorting to eliminate concurrent modification issues
- Removes the post-processing sorting loop that was vulnerable to race conditions
- Adds TreeMap import to support the new implementation
Comments suppressed due to low confidence (1)
architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/artifactsgenerator/ArtifactsGenerator.java:1
- The LinkedHashMap import is no longer used after removing the manual sorting logic and should be removed to clean up unused imports.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2def608 to
fc398bb
Compare
...e-model-generator-core/src/main/java/io/ballerina/artifactsgenerator/ArtifactsGenerator.java
Show resolved
Hide resolved
NipunaRanasinghe
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
artifacts()method was throwing anArrayIndexOutOfBoundsExceptionduring the sorting operation due to a concurrency issue in the sorting process.Addresses wso2/product-ballerina-integrator#1178