Handle entire expression deletion in select and root expressions#293
Merged
KavinduZoysa merged 5 commits intoballerina-platform:1.2.xfrom Sep 9, 2025
Merged
Conversation
…1069 # Conflicts: # flow-model-generator/modules/flow-model-generator-ls-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingDeleteTest.java
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the data mapping deletion functionality by handling entire expression deletion in select and root expressions, addressing issue #1069 in the Ballerina integrator.
- Adds support for deleting entire expressions in function bodies and select clauses
- Implements proper default value replacement when expressions are deleted
- Expands test coverage with new test cases for various deletion scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| variable6.bal | Test source file with function definition and query expression structures |
| variable8.json | Test configuration for function expression deletion scenario |
| variable9.json | Test configuration for query select clause deletion scenario |
| DataMappingDeleteTest.java | Adds new test cases to cover expression deletion scenarios |
| DataMapManager.java | Core logic enhancement to handle expression deletion in function bodies and select clauses |
Comments suppressed due to low confidence (1)
flow-model-generator/modules/flow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java:1
- The variable
functionTypeSymbolis assigned but never used. You can directly chain the method call:Optional<TypeSymbol> returnType = functionSymbol.typeDescriptor().returnTypeDescriptor();
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KavinduZoysa
reviewed
Sep 9, 2025
...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java
Outdated
Show resolved
Hide resolved
KavinduZoysa
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses : wso2/product-ballerina-integrator#1069