Skip to content

Handle entire expression deletion in select and root expressions#293

Merged
KavinduZoysa merged 5 commits intoballerina-platform:1.2.xfrom
pasindufernando1:deleteMappingIssue1069
Sep 9, 2025
Merged

Handle entire expression deletion in select and root expressions#293
KavinduZoysa merged 5 commits intoballerina-platform:1.2.xfrom
pasindufernando1:deleteMappingIssue1069

Conversation

@pasindufernando1
Copy link
Contributor

…1069

# Conflicts:
#	flow-model-generator/modules/flow-model-generator-ls-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingDeleteTest.java
Copilot AI review requested due to automatic review settings September 8, 2025 10:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the data mapping deletion functionality by handling entire expression deletion in select and root expressions, addressing issue #1069 in the Ballerina integrator.

  • Adds support for deleting entire expressions in function bodies and select clauses
  • Implements proper default value replacement when expressions are deleted
  • Expands test coverage with new test cases for various deletion scenarios

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
variable6.bal Test source file with function definition and query expression structures
variable8.json Test configuration for function expression deletion scenario
variable9.json Test configuration for query select clause deletion scenario
DataMappingDeleteTest.java Adds new test cases to cover expression deletion scenarios
DataMapManager.java Core logic enhancement to handle expression deletion in function bodies and select clauses
Comments suppressed due to low confidence (1)

flow-model-generator/modules/flow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java:1

  • The variable functionTypeSymbol is assigned but never used. You can directly chain the method call: Optional<TypeSymbol> returnType = functionSymbol.typeDescriptor().returnTypeDescriptor();
/*

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@KavinduZoysa KavinduZoysa merged commit 62f893d into ballerina-platform:1.2.x Sep 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants