Ensure predictable Ballerina dependency resolution in workflows#299
Draft
nipunayf wants to merge 4 commits intoballerina-platform:1.2.xfrom
Draft
Ensure predictable Ballerina dependency resolution in workflows#299nipunayf wants to merge 4 commits intoballerina-platform:1.2.xfrom
nipunayf wants to merge 4 commits intoballerina-platform:1.2.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures predictable Ballerina dependency resolution by replacing the use of bal pull with a Ballerina.toml file specifying dependency versions with the --sticky flag for builds.
- Removes version definitions from
gradle.propertiesand individual modulebal pullcommands - Creates a centralized dependency management approach using
Ballerina.tomlwith sticky builds - Temporarily disables Mistral AI provider tests due to dependency resolution issues
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | Removes version variables for Ballerinax modules and fixes naming inconsistencies |
| build-config/ballerina_dependencies/Ballerina.toml | Adds centralized dependency configuration with sticky build option |
| build-config/ballerina_dependencies/main.bal | Creates placeholder file with imports for all required dependencies |
| flow-model-generator/modules/flow-model-generator-ls-extension/build.gradle | Removes individual bal pull commands for modules |
| GetNodeTemplateTest.java | Comments out Mistral test case with tracking reference |
| CodeGenerationTest.java | Comments out Mistral test case with tracking reference |
| architecture-model-generator/modules/architecture-model-generator-ls-extension/build.gradle | Adds --sticky flag to tool pull commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
52b2b17 to
1ed96e4
Compare
73115bd to
e62f2f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, the only way to lock transitive dependency versions is by specifying the required version in
Ballerina.tomland building with the--stickyflag. This PR updates the existing usage ofbal pullto follow this approach.Fixes wso2/product-ballerina-integrator#1245