Provide completions for expressions within the data mapper#434
Merged
nipunayf merged 4 commits intoballerina-platform:1.2.xfrom Oct 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the compiler API implementation to provide code completions for expressions within the data mapper by generating temporary wrapper functions with required variables. This is a workaround solution until a proper API extension is available.
Key Changes:
- Added a new
DATA_MAPPING_EXPRESSIONvalue type to handle data mapper expressions - Implemented temporary function wrapper generation to enable completions for data mapper contexts
- Added comprehensive test coverage with multiple completion scenarios
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Property.java | Adds DATA_MAPPING_EXPRESSION enum value |
| CompletionRequest.java | Implements special handling for data mapper expressions by generating wrapper functions |
| ExpressionEditorContext.java | Adds generateFunctionDefinition() method to create temporary function wrappers |
| data_mapper.bal | Removes trailing whitespace |
| proj17-23.json | New test files covering various completion scenarios in data mapper context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...n/java/io/ballerina/flowmodelgenerator/core/expressioneditor/services/CompletionRequest.java
Show resolved
Hide resolved
...n/java/io/ballerina/flowmodelgenerator/core/expressioneditor/services/CompletionRequest.java
Outdated
Show resolved
Hide resolved
...main/java/io/ballerina/flowmodelgenerator/core/expressioneditor/ExpressionEditorContext.java
Outdated
Show resolved
Hide resolved
nipunayf
force-pushed
the
data-mapper-expression-completions
branch
from
3fab1ba to
db2fd23
Compare
This was referenced Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The PR extends the current implementation of the compiler API to handle special expressions in the data mapper by generating wrapper functions with the required variables for completions. Note that this is a temporary solution until a proper API extension is implemented.
Fixes wso2/product-ballerina-integrator#1287