Fix the usage between the base workspace manager and the cloned workspace manager#435
Merged
nipunayf merged 1 commit intoballerina-platform:1.2.xfrom Oct 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incorrect routing of workspace manager calls between the base and cloned workspace managers based on URI schemes. The previous implementation allowed didChange events to be processed by the cloned workspace manager without a corresponding didOpen event, causing breakage when creating new files.
Key changes:
- Corrected the conditional logic to route
didOpencalls appropriately between base and cloned workspace managers - Fixed
didChangeto only route to the cloned workspace manager for expression scheme URIs - Aligned
didCloseto use consistent if-else structure instead of early return
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NipunaRanasinghe
approved these changes
Oct 25, 2025
This was referenced Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$title as this causes a breakage in the didChange API when a new file is created.
I went through the original changes in ballerina-platform/ballerina-lang#42911, and they seem invalid for two reasons:
Ideally, this should be fixed along with wso2/product-ballerina-integrator#1488. But for now, I made the changes compliant with the new expression editor service.
Fixes wso2/product-ballerina-integrator#1604