Fix the NPE caused by moduleInfo.packageName()#438
Merged
nipunayf merged 1 commit intoballerina-platform:1.2.xfrom Oct 26, 2025
Merged
Fix the NPE caused by moduleInfo.packageName()#438nipunayf merged 1 commit intoballerina-platform:1.2.xfrom
moduleInfo.packageName()#438nipunayf merged 1 commit intoballerina-platform:1.2.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a NullPointerException (NPE) by adding proper null checks for moduleInfo.packageName() in the isLocal() method. The fix restructures the logic to handle null values defensively and provides a fallback to moduleName when packageName is null.
Key Changes:
- Inverted the initial null check to use early return pattern
- Added null check for
packageNamebefore callingstartsWith() - Introduced fallback logic using
moduleNamewhenpackageNameis null
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...generator-commons/src/main/java/io/ballerina/modelgenerator/commons/FunctionDataBuilder.java
Show resolved
Hide resolved
NipunaRanasinghe
approved these changes
Oct 26, 2025
This was referenced Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$title as it lacks a null check.
Fixes wso2/product-ballerina-integrator#1606