Fix the failures in the GitHub workflows#6
Merged
NipunaRanasinghe merged 16 commits intoballerina-platform:mainfrom May 26, 2025
Merged
Fix the failures in the GitHub workflows#6NipunaRanasinghe merged 16 commits intoballerina-platform:mainfrom
NipunaRanasinghe merged 16 commits intoballerina-platform:mainfrom
Conversation
aa4acb4 to
48609e3
Compare
48609e3 to
baa6549
Compare
171a2c6 to
fc61f67
Compare
50f60c1 to
26e329d
Compare
26e329d to
be0851a
Compare
d10bb96 to
6217ef8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes failures in GitHub workflows by addressing OOM issues in Ballerina tests, resolving filename issues on Windows, switching to the local language server core for extended services, and updating various dependency versions and test cases.
- Explicit null assignments have been introduced after shutting down the language server to ensure cleanup.
- Multiple build and configuration files have been updated to use project dependencies for langserver components and new library versions.
- Minor adjustments in test utility methods now use getPath instead of getCanonicalPath to resolve Windows filename issues.
Reviewed Changes
Copilot reviewed 66 out of 66 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| langserver-core/src/test/java/org/ballerinalang/langserver/diagnostics/DiagnosticsTest.java | Added null assignment to serviceEndpoint after shutdown for cleanup consistency |
| langserver-core/src/test/java/org/ballerinalang/langserver/diagnostics/CyclicDependenciesTest.java | Refactored instance variable initialization using @BeforeClass and @afterclass |
| langserver-core/src/test/java/org/ballerinalang/langserver/definition/DefinitionTest.java | Replaced getCanonicalPath with getPath to address Windows filename issues |
| langserver-core/src/test/java/org/ballerinalang/langserver/command/AbstractCommandExecutionTest.java | Added null assignment for serviceEndpoint post shutdown |
| langserver-core/src/test/java/org/ballerinalang/langserver/codelenses/CodeLensTest.java | Consistent cleanup of serviceEndpoint is applied |
| Multiple build.gradle and gradle.properties files | Updated dependency declarations to use langserver-core and langserver-commons projects; bumped version numbers |
| .github/workflows/pull-request.yml | Enabled long paths for Git to better support Windows file handling |
| .gitattributes | Standardized end-of-line configuration for Java files |
| Various JSON test config files | Updated version numbers and packageInfo fields to reflect new library versions |
| flow-model-generator modules | Adjusted module dependencies and added a TODO in test skip lists for investigation on GitHub Actions |
Comments suppressed due to low confidence (3)
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/SearchTest.java:70
- [nitpick] Consider linking this TODO to a tracking issue for improved clarity and management of the failing test.
// TODO: Investigate why this test fails on Github Actions
langserver-core/src/test/java/org/ballerinalang/langserver/definition/DefinitionTest.java:205
- Replacing getCanonicalPath with getPath may yield different path resolutions; please ensure this change resolves Windows filename issues without unintended side effects.
item.addProperty("uri", expectedPath.toFile().getPath());
langserver-core/src/test/java/org/ballerinalang/langserver/definition/DefinitionTest.java:265
- Switching to getPath can alter path normalization behavior; please verify that the intended file path format is maintained consistently across environments.
item.addProperty("uri", new File(canonicalPath).getPath());
NipunaRanasinghe
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The following changes are addressed with this PR: