Skip to content

Comments

Fix editing of anonymous records in HTTP and enable imported types for data binding#650

Merged
LakshanWeerasinghe merged 8 commits intoballerina-platform:1.5.xfrom
LakshanWeerasinghe:fix#1931
Jan 27, 2026
Merged

Fix editing of anonymous records in HTTP and enable imported types for data binding#650
LakshanWeerasinghe merged 8 commits intoballerina-platform:1.5.xfrom
LakshanWeerasinghe:fix#1931

Conversation

@LakshanWeerasinghe
Copy link
Contributor

Purpose

$subject

HTTP Response Form
Fixed an issue where responses containing anonymous records could not be edited.
Fixes wso2/product-ballerina-integrator#1661

Data Binding
Added support for imported types in data binding parameters for triggers like Kafka and RabbitMQ.
Fixes wso2/product-ballerina-integrator#1931

@LakshanWeerasinghe LakshanWeerasinghe marked this pull request as draft January 21, 2026 12:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses two key issues in the service model generator:

Purpose:
Fixes editing capabilities for HTTP responses containing anonymous records and adds support for imported types in data binding parameters for triggers like Kafka and RabbitMQ.

Changes:

  • Modified HTTP response generation to allow editing of anonymous records by setting the editable flag appropriately
  • Extended data binding functionality to handle imported types by extracting and propagating import information through type definition creation
  • Updated the HttpResponse model to support setting editable and enabled flags via the builder pattern

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
HttpUtil.java Refactored HTTP response building to properly set editable and enabled flags, enabling editing of anonymous record responses
DatabindUtil.java Added support for extracting and propagating import information from data binding parameters to type definitions
HttpResponse.java Enhanced builder pattern to accept editable and enabled flags, simplifying response construction
kafka_bind_imported_type.json Test configuration demonstrating imported type handling in Kafka data binding
add_kafka_on_consumer_record.json Test configuration for adding Kafka consumer with imported types
http_response_*.json Updated test expectations to reflect editable anonymous records
http_methods_*.json Updated test expectations for various HTTP methods with editable responses
Ballerina.toml Test project configuration files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LakshanWeerasinghe LakshanWeerasinghe merged commit b76cead into ballerina-platform:1.5.x Jan 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants