Add sql support for expression editor#666
Add sql support for expression editor#666NipunaRanasinghe merged 9 commits intoballerina-platform:1.6.xfrom
Conversation
e39e6cd to
cc53e30
Compare
cc53e30 to
f0f1289
Compare
f0f1289 to
e9b2114
Compare
...tor-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/model/Value.java
Outdated
Show resolved
Hide resolved
...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/model/Property.java
Outdated
Show resolved
Hide resolved
...ow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/CodeAnalyzer.java
Outdated
Show resolved
Hide resolved
...ow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/CodeAnalyzer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This pull request adds SQL query support to the expression editor by introducing a new SQL_QUERY value type for handling SQL parameterized queries. The changes enable the expression editor to distinguish SQL queries from generic expressions, providing better support for SQL database operations in the Ballerina flow model generator.
Changes:
- Added
SQL_QUERYas a newValueTypeenum in the Property model for specialized SQL query handling - Updated parameter type detection logic to identify and handle
sql:ParameterizedQuerytypes withSQL_QUERYas the primary field type - Refactored Optional handling throughout CodeAnalyzer to safely check for empty parameter names before processing
- Updated test configurations to reflect SQL_QUERY as the selected type instead of EXPRESSION for SQL query parameters
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Property.java | Added SQL_QUERY enum value and SQL_PARAMETERIZED_QUERY constant; implemented detection logic for SQL query types in handlePrimitiveType method |
| CodeAnalyzer.java | Added PARAMETERIZED_QUERY constant; implemented SQL query type detection in buildPropertyType; refactored Optional handling for parameter names; inlined hasQualifier method; refactored retry statement parsing |
| DiagnosticsRequest.java | Extended switch statement to handle SQL_QUERY field type using ExpressionDiagnosticsRequest |
| Test JSON configs | Updated test expectations to show SQL_QUERY as selected type with EXPRESSION as fallback for SQL query parameters |
| Test source files | Added new test cases demonstrating SQL query functionality with mssql client |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/CodeAnalyzer.java
Show resolved
Hide resolved
...ow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/CodeAnalyzer.java
Outdated
Show resolved
Hide resolved
...ow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/CodeAnalyzer.java
Outdated
Show resolved
Hide resolved
...ow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/CodeAnalyzer.java
Show resolved
Hide resolved
...ow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/CodeAnalyzer.java
Show resolved
Hide resolved
|
@samithkavishke just a quick heads-up to keep PRs focused on a single responsibility. |
Purpose
LS Support wso2/product-ballerina-integrator#633
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning