Refactor migration libraries API#672
Conversation
48d3e3d to
b6fabdc
Compare
b6fabdc to
d22b281
Compare
d22b281 to
23e49de
Compare
...ore/src/main/java/io/ballerina/flowmodelgenerator/core/model/adapters/StringPathAdapter.java
Show resolved
Hide resolved
| for (Symbol symbol : semanticModel.moduleSymbols()) { | ||
| switch (symbol.kind()) { | ||
| case CLASS: | ||
| ClassSymbolHandler.process( |
There was a problem hiding this comment.
Is this the pattern we use in this codebase?
Not a big fan of this since it only has a normal class with static process function?
There was a problem hiding this comment.
Seems like other usages don't use visitors either. If the handlers are short, we can revert back to handling it here itself.
| // Add varType using ConstantValue | ||
| String varTypeName = ""; | ||
| Object constValue = constantSymbol.constValue(); | ||
| if (constValue instanceof ConstantValue constantValue) { |
There was a problem hiding this comment.
Check if theres a kind or type which we can do instanceof. There is, we should follow that approach
xlight05
left a comment
There was a problem hiding this comment.
Lets address these too before merging this to main
| for (Symbol symbol : semanticModel.moduleSymbols()) { | ||
| switch (symbol.kind()) { | ||
| case CLASS: | ||
| ClassSymbolHandler.process( |
There was a problem hiding this comment.
Seems like other usages don't use visitors either. If the handlers are short, we can revert back to handling it here itself.
ed970e1
into
ballerina-platform:copilot-library-unify
|
We should move Copilot sepcific stuff to a package inside core |
Description
This PR resolves comments for the PR: #636 (comment)
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning