Skip to content

Comments

Add Listener Type Name as a Property of Listener Model#685

Merged
LakshanWeerasinghe merged 4 commits intoballerina-platform:1.6.xfrom
LakshanWeerasinghe:fix#2403
Feb 10, 2026
Merged

Add Listener Type Name as a Property of Listener Model#685
LakshanWeerasinghe merged 4 commits intoballerina-platform:1.6.xfrom
LakshanWeerasinghe:fix#2403

Conversation

@LakshanWeerasinghe
Copy link
Contributor

@LakshanWeerasinghe LakshanWeerasinghe commented Feb 10, 2026

Purpose

$subject

Fixes wso2/product-ballerina-integrator#2403

Screen.Recording.2026-02-10.at.14.37.20.mov

@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the language-server service model generator’s Listener model to carry the concrete listener type name (e.g., Listener, WebSocketListener) as an explicit property, and uses that value when rendering listener declarations/expressions and when building listener models from source.

Changes:

  • Add a new listenerType property to the Listener model and populate it across listener-model creation paths.
  • Update listener declaration/expression rendering to use protocol:<listenerType> instead of hard-coding protocol:Listener.
  • Update JSON test fixtures for get/update/listener-from-source scenarios to include the new property and request type.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
service-model-generator/modules/service-model-generator-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/util/ListenerUtil.java Adds listenerType property to base listener models and sets it when building models from source/request.
service-model-generator/modules/service-model-generator-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/util/Constants.java Introduces PROP_KEY_LISTENER_TYPE and DEFAULT_LISTENER_TYPE.
service-model-generator/modules/service-model-generator-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/model/Listener.java Uses listenerType property when generating listener declarations/expressions and exposes a getter.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/update_listener/config/update_http_listener.json Updates update-listener fixture to include listenerType.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_1.json Updates fixture to include listenerType.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_2.json Updates fixture to include listenerType.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_3.json Updates fixture to include listenerType.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_4.json Updates fixture to include listenerType.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_5.json Updates fixture to include listenerType.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/get_listener_model/config/http_listener_model.json Updates get-listener-model fixture to include request type and listenerType property.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/get_listener_model/config/graphql_listener_model.json Updates get-listener-model fixture to include request type and listenerType property.
service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/get_listener_model/config/kafka_listener_model.json Updates get-listener-model fixture to include request type and listenerType property.
Comments suppressed due to low confidence (1)

service-model-generator/modules/service-model-generator-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/model/Listener.java:293

        public ListenerBuilder setProperties(Map<String, Value> properties) {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LakshanWeerasinghe LakshanWeerasinghe marked this pull request as ready for review February 10, 2026 10:08
@LakshanWeerasinghe LakshanWeerasinghe merged commit c8d56a3 into ballerina-platform:1.6.x Feb 10, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants