Add Listener Type Name as a Property of Listener Model#685
Add Listener Type Name as a Property of Listener Model#685LakshanWeerasinghe merged 4 commits intoballerina-platform:1.6.xfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR extends the language-server service model generator’s Listener model to carry the concrete listener type name (e.g., Listener, WebSocketListener) as an explicit property, and uses that value when rendering listener declarations/expressions and when building listener models from source.
Changes:
- Add a new
listenerTypeproperty to the Listener model and populate it across listener-model creation paths. - Update listener declaration/expression rendering to use
protocol:<listenerType>instead of hard-codingprotocol:Listener. - Update JSON test fixtures for get/update/listener-from-source scenarios to include the new property and request
type.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| service-model-generator/modules/service-model-generator-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/util/ListenerUtil.java | Adds listenerType property to base listener models and sets it when building models from source/request. |
| service-model-generator/modules/service-model-generator-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/util/Constants.java | Introduces PROP_KEY_LISTENER_TYPE and DEFAULT_LISTENER_TYPE. |
| service-model-generator/modules/service-model-generator-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/model/Listener.java | Uses listenerType property when generating listener declarations/expressions and exposes a getter. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/update_listener/config/update_http_listener.json | Updates update-listener fixture to include listenerType. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_1.json | Updates fixture to include listenerType. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_2.json | Updates fixture to include listenerType. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_3.json | Updates fixture to include listenerType. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_4.json | Updates fixture to include listenerType. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/listener_from_source/config/listener_from_source_5.json | Updates fixture to include listenerType. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/get_listener_model/config/http_listener_model.json | Updates get-listener-model fixture to include request type and listenerType property. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/get_listener_model/config/graphql_listener_model.json | Updates get-listener-model fixture to include request type and listenerType property. |
| service-model-generator/modules/service-model-generator-ls-extension/src/test/resources/get_listener_model/config/kafka_listener_model.json | Updates get-listener-model fixture to include request type and listenerType property. |
Comments suppressed due to low confidence (1)
service-model-generator/modules/service-model-generator-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/model/Listener.java:293
- setProperties exposes the internal representation stored in field properties. The value may be modified through the variable properties.
setProperties exposes the internal representation stored in field properties. The value may be modified through the variable properties.
public ListenerBuilder setProperties(Map<String, Value> properties) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/util/ListenerUtil.java
Show resolved
Hide resolved
...-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/model/Listener.java
Show resolved
Hide resolved
...-ls-extension/src/main/java/io/ballerina/servicemodelgenerator/extension/model/Listener.java
Show resolved
Hide resolved
c8d56a3
into
ballerina-platform:1.6.x
Purpose
$subject
Fixes wso2/product-ballerina-integrator#2403
Screen.Recording.2026-02-10.at.14.37.20.mov