-
Notifications
You must be signed in to change notification settings - Fork 36
Improve the name of the triggers in the artifacts list #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LakshanWeerasinghe
wants to merge
2
commits into
ballerina-platform:1.6.x
Choose a base branch
from
LakshanWeerasinghe:fix#658
base: 1.6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
178 changes: 178 additions & 0 deletions
178
...architecture-model-generator-ls-extension/src/test/resources/artifacts/config/github.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,178 @@ | ||
| { | ||
| "description": "", | ||
| "source": "github.bal", | ||
| "packageName": ".", | ||
| "output": { | ||
| "Listeners": { | ||
| "githubListener": { | ||
| "id": "githubListener", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 2, | ||
| "offset": 0 | ||
| }, | ||
| "endLine": { | ||
| "line": 2, | ||
| "offset": 49 | ||
| } | ||
| }, | ||
| "type": "LISTENER", | ||
| "name": "githubListener", | ||
| "scope": "Global", | ||
| "icon": "https://bcentral-packageicons.azureedge.net/images/ballerinax_trigger.github_0.10.0.png", | ||
| "module": "trigger.github", | ||
| "children": {} | ||
| } | ||
| }, | ||
| "Entry Points": { | ||
| "628752842": { | ||
| "id": "628752842", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 4, | ||
| "offset": 0 | ||
| }, | ||
| "endLine": { | ||
| "line": 60, | ||
| "offset": 1 | ||
| } | ||
| }, | ||
| "type": "SERVICE", | ||
| "name": "GitHub Event Integration - github:IssuesService", | ||
| "scope": "Global", | ||
| "icon": "https://bcentral-packageicons.azureedge.net/images/ballerinax_trigger.github_0.10.0.png", | ||
| "module": "trigger.github", | ||
| "children": { | ||
| "onOpened": { | ||
| "id": "onOpened", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 5, | ||
| "offset": 4 | ||
| }, | ||
| "endLine": { | ||
| "line": 11, | ||
| "offset": 5 | ||
| } | ||
| }, | ||
| "type": "REMOTE", | ||
| "name": "onOpened", | ||
| "scope": "Global", | ||
| "children": {} | ||
| }, | ||
| "onClosed": { | ||
| "id": "onClosed", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 13, | ||
| "offset": 4 | ||
| }, | ||
| "endLine": { | ||
| "line": 19, | ||
| "offset": 5 | ||
| } | ||
| }, | ||
| "type": "REMOTE", | ||
| "name": "onClosed", | ||
| "scope": "Global", | ||
| "children": {} | ||
| }, | ||
| "onReopened": { | ||
| "id": "onReopened", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 21, | ||
| "offset": 4 | ||
| }, | ||
| "endLine": { | ||
| "line": 27, | ||
| "offset": 5 | ||
| } | ||
| }, | ||
| "type": "REMOTE", | ||
| "name": "onReopened", | ||
| "scope": "Global", | ||
| "children": {} | ||
| }, | ||
| "onAssigned": { | ||
| "id": "onAssigned", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 29, | ||
| "offset": 4 | ||
| }, | ||
| "endLine": { | ||
| "line": 35, | ||
| "offset": 5 | ||
| } | ||
| }, | ||
| "type": "REMOTE", | ||
| "name": "onAssigned", | ||
| "scope": "Global", | ||
| "children": {} | ||
| }, | ||
| "onLabeled": { | ||
| "id": "onLabeled", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 45, | ||
| "offset": 4 | ||
| }, | ||
| "endLine": { | ||
| "line": 51, | ||
| "offset": 5 | ||
| } | ||
| }, | ||
| "type": "REMOTE", | ||
| "name": "onLabeled", | ||
| "scope": "Global", | ||
| "children": {} | ||
| }, | ||
| "onUnlabeled": { | ||
| "id": "onUnlabeled", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 53, | ||
| "offset": 4 | ||
| }, | ||
| "endLine": { | ||
| "line": 59, | ||
| "offset": 5 | ||
| } | ||
| }, | ||
| "type": "REMOTE", | ||
| "name": "onUnlabeled", | ||
| "scope": "Global", | ||
| "children": {} | ||
| }, | ||
| "onUnassigned": { | ||
| "id": "onUnassigned", | ||
| "location": { | ||
| "fileName": "github.bal", | ||
| "startLine": { | ||
| "line": 37, | ||
| "offset": 4 | ||
| }, | ||
| "endLine": { | ||
| "line": 43, | ||
| "offset": 5 | ||
| } | ||
| }, | ||
| "type": "REMOTE", | ||
| "name": "onUnassigned", | ||
| "scope": "Global", | ||
| "children": {} | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
61 changes: 61 additions & 0 deletions
61
.../architecture-model-generator-ls-extension/src/test/resources/artifacts/source/github.bal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import ballerinax/trigger.github; | ||
|
|
||
| listener github:Listener githubListener = new (); | ||
|
|
||
| service github:IssuesService on githubListener { | ||
| remote function onOpened(github:IssuesEvent payload) returns error|() { | ||
| do { | ||
| } on fail error err { | ||
| // handle error | ||
| return error("unhandled error", err); | ||
| } | ||
| } | ||
|
|
||
| remote function onClosed(github:IssuesEvent payload) returns error|() { | ||
| do { | ||
| } on fail error err { | ||
| // handle error | ||
| return error("unhandled error", err); | ||
| } | ||
| } | ||
|
|
||
| remote function onReopened(github:IssuesEvent payload) returns error|() { | ||
| do { | ||
| } on fail error err { | ||
| // handle error | ||
| return error("unhandled error", err); | ||
| } | ||
| } | ||
|
|
||
| remote function onAssigned(github:IssuesEvent payload) returns error|() { | ||
| do { | ||
| } on fail error err { | ||
| // handle error | ||
| return error("unhandled error", err); | ||
| } | ||
| } | ||
|
|
||
| remote function onUnassigned(github:IssuesEvent payload) returns error|() { | ||
| do { | ||
| } on fail error err { | ||
| // handle error | ||
| return error("unhandled error", err); | ||
| } | ||
| } | ||
|
|
||
| remote function onLabeled(github:IssuesEvent payload) returns error|() { | ||
| do { | ||
| } on fail error err { | ||
| // handle error | ||
| return error("unhandled error", err); | ||
| } | ||
| } | ||
|
|
||
| remote function onUnlabeled(github:IssuesEvent payload) returns error|() { | ||
| do { | ||
| } on fail error err { | ||
| // handle error | ||
| return error("unhandled error", err); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the
github:prefix? It seems redundant since we are already specifying the type at start. Also, since only a small width is typically allocated for artifacts, most of the text would overflow.