Skip to content

Comments

Revert FTP integration improvements from 1.6.x#717

Closed
niveathika wants to merge 20 commits intoballerina-platform:1.6.xfrom
niveathika:revert/ftp-improvements-1.6.x
Closed

Revert FTP integration improvements from 1.6.x#717
niveathika wants to merge 20 commits intoballerina-platform:1.6.xfrom
niveathika:revert/ftp-improvements-1.6.x

Conversation

@niveathika
Copy link
Contributor

@niveathika niveathika commented Feb 18, 2026

Summary

Reverts #692
Reverts the FTP integration improvement set from 1.6.x so it can be carried via main instead.

Reverted commits

  • Revert "Fix testcases" (cbf07055e9)
  • Revert "Fix SpotBugs issues in FTP builders" (e4dbb57c13)
  • Revert "Fix checkstyle failures" (74614a8909)
  • Revert "Filter deprecated listener params and harden listener model resolution" (8e19eaa27d)
  • Revert "Add FTP post-process actions for success/error" (04997d5ce0)

Notes

  • Includes one follow-up compile fix for PackageUtil conflict resolution while reverting.

Validation

  • ./gradlew :service-model-generator:service-model-generator-ls-extension:compileJava -x spotbugsMain

@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@samithkavishke
Copy link
Contributor

There is a check style violation can you resolve

@niveathika
Copy link
Contributor Author

@samithkavishke Fixed with faa44f4

@niveathika niveathika force-pushed the revert/ftp-improvements-1.6.x branch from 7305e72 to aa87e4d Compare February 18, 2026 08:43
@samithkavishke
Copy link
Contributor

@niveathika can you check this since original PR contains 19 files changed and this does not include all

Copy link
Contributor

@samithkavishke samithkavishke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files does not match exactly the original PR changes

@niveathika
Copy link
Contributor Author

I have cleaned up the branch without the PR

@niveathika niveathika closed this Feb 19, 2026
@niveathika niveathika deleted the revert/ftp-improvements-1.6.x branch February 19, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants