Make the default name in function craetion node#729
Merged
KavinduZoysa merged 1 commit intoballerina-platform:1.7.xfrom Feb 24, 2026
Merged
Make the default name in function craetion node#729KavinduZoysa merged 1 commit intoballerina-platform:1.7.xfrom
KavinduZoysa merged 1 commit intoballerina-platform:1.7.xfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
...src/main/java/io/ballerina/flowmodelgenerator/core/model/node/DataMapperCreationBuilder.java
Outdated
Show resolved
Hide resolved
0fc1064 to
1508baa
Compare
dulajdilshan
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses wso2/product-ballerina-integrator#2515
Summary
This pull request refactors the default naming mechanism for function creation nodes in the Ballerina flow model generator. The changes establish a consistent pattern for defining and retrieving default function names across different node types.
Changes
Core Implementation Updates:
FUNCTION_NAME) in both theDataMapperCreationBuilderandFunctionCreationBuilderclassesgetFunctionName()method inDataMapperCreationBuilderthat returns the constant, and override it inFunctionCreationBuilderto return "function" instead of the parent class default "transform"Test Data Updates:
Intent
These changes improve code maintainability by centralizing default name definitions and create a flexible extension pattern. Subclasses can now easily override the default function name without relying on string literals scattered throughout the codebase. This addresses the inconsistency in default naming for function creation nodes and aligns with the intended behavior referenced in issue #2515.