Fix: Return modified modules list in build_standard_library.py

[chawdamrunal]

Description

Fixes: #8347

Fixes a logic bug in get_stdlib_module_list() function where the modified modules list was not being returned.

Problem

The function was building a modified modules list throughout its execution (adding extended_modules, connectors, tools, and distribution when requested), but was returning the original unmodified module_list["modules"] instead.

This caused command-line flags to be ignored:

• --build-extended-modules
• --build-connectors
• --build-tools
• --build-distribution

Solution

Changed line 368 in resources/scripts/build_standard_library.py:

• Before: return module_list["modules"]
• After: return modules

Impact

Users can now successfully build extended modules, connectors, tools, and distribution when using the respective command-line flags.

Testing

• Verified the logic fix addresses the root cause
• No breaking changes introduced
• Code follows project standards

Related

• Identified during security audit/code review
• This is a functional bug fix that improves build script reliability

---

Note: This is a Hacktoberfest contribution 🎃

Checklist:

• Code follows the project's coding standards
• Fix addresses the root cause of the issue
• No breaking changes introduced

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Mrunal Chawda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[chawdamrunal]

🎃 This PR is part of Hacktoberfest 2024!

I noticed this bug during a security audit of the codebase. The fix is straightforward - ensuring the modified modules list is returned so that the build flags work as intended.

Happy to make any changes if needed!

[Copilot]

Pull Request Overview

This PR fixes a logic bug in the get_stdlib_module_list() function where the function was incorrectly returning the original unmodified module list instead of the accumulated modules variable. This bug prevented command-line flags (--build-extended-modules, --build-connectors, --build-tools, --build-distribution) from working correctly.

• Fixed return statement to return the modified modules list instead of the original module_list["modules"]

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[ThisaruGuruge]

Hi @chawdamrunal

Thank you for your contribution.

It would be better if you can create an issue for the fix, and tag it in this PR, so that we can assign hacktoberfest credits for you.

Then, please sign the CLA so that we can merge your PR.

[chawdamrunal]

@ThisaruGuruge, I have signed the CLA. Kindly check.

[ThisaruGuruge]

@ThisaruGuruge, I have signed the CLA. Kindly check.

It still says you have not signed. Can you please check whether your commits are done using the GitHub account email? Usually this happens when your commits have a different user email than the GitHub one.

[chawdamrunal]

@ThisaruGuruge, it seems like the main root cause. Kindly close the PR I'll raise it again.

[daneshk]

@ThisaruGuruge, it seems like the main root cause. Kindly close the PR I'll raise it again.

I closed the PR. please open a new PR