Remove Redundant CDS Package Override based on FHIR Version#117
Merged
Thiyanwso2 merged 1 commit intoballerina-platform:mainfrom Jul 30, 2025
Merged
Remove Redundant CDS Package Override based on FHIR Version#117Thiyanwso2 merged 1 commit intoballerina-platform:mainfrom
Thiyanwso2 merged 1 commit intoballerina-platform:mainfrom
Conversation
Sanjana-Attanayake
requested review from
isuruh15 and
sameeragunarathne
as code owners
Thiyanwso2
suggested changes
Jul 30, 2025
native/health-cli/src/main/java/io/ballerina/health/cmd/handler/CrdTemplateGenHandler.java
Show resolved
Hide resolved
Thiyanwso2
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Initially it was assumed that the CDS templates generation was version dependent as the tool-config stated that the the base and dependent package for CDS generation resides in the r4 module library.
According to further discussion it was identified that the CDS template generation is FHIR version independent and the packages just reside in the repository for r4. Thus the codes for overriding became unnecessary even for future developments.
Goals
Removes the redundant logics to remove the CDS package import from FHIR version specific library modules.
Approach
Through discussions it was noted that the CDS template generation is FHIR version independent.
Security checks
Related PRs
Extend Ballerina Health Tool for R5
Test environment
JDK: 21
Ballerina: 2201.12.3
OS: Windows 11