Skip to content

Comments

Avoid throwing error for 'bal test --cloud='k8s'#834

Closed
xlight05 wants to merge 1 commit intoballerina-platform:masterfrom
xlight05:ignore-k8s-test
Closed

Avoid throwing error for 'bal test --cloud='k8s'#834
xlight05 wants to merge 1 commit intoballerina-platform:masterfrom
xlight05:ignore-k8s-test

Conversation

@xlight05
Copy link
Contributor

@xlight05 xlight05 commented Feb 22, 2025

Purpose

$Subject
Resolves ballerina-platform/ballerina-library#7621

@anuruddhal @Dilhasha Should we print a warning instead saying tests will not in this case?

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@xlight05 xlight05 requested a review from anuruddhal as a code owner February 22, 2025 17:08
@Dilhasha
Copy link

@xlight05
I don't think we need a warning here. It might only add more confusion IMO.
Let's move forward with the same way it was in 9.x i.e. just skip. WDYT?

@xlight05
Copy link
Contributor Author

xlight05 commented Feb 23, 2025

@xlight05 I don't think we need a warning here. It might only add more confusion IMO. Let's move forward with the same way it was in 9.x i.e. just skip. WDYT?

Only thing is, when k8s flag is there, tests won't be executed, even locally, if that behavior is the intended behavior, lets merge this

@Dilhasha
Copy link

@xlight05 I don't think we need a warning here. It might only add more confusion IMO. Let's move forward with the same way it was in 9.x i.e. just skip. WDYT?

Only thing is, when k8s flag is there, tests won't be expected, even locall, if that behavior is the intended behavior, lets merge this

It's not intentional not to run the tests. We might need a fix from lang-side too then.

@Dilhasha
Copy link

Dilhasha commented Mar 12, 2025

@xlight05 Shall we improve the error message as discussed?

Suggestion:

testing on the cloud is not supported for Kubernetes. Please remove the --cloud=k8s option when running tests.

WDYT?

@anuruddhal anuruddhal closed this Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: C2C plugin throws an error during bal test when flag to generate k8s artifacts is enabled

3 participants