Skip to content

Comments

Fix port conflicts for shared listeners#849

Merged
anuruddhal merged 1 commit intoballerina-platform:masterfrom
anuruddhal:2201.12.x
Aug 27, 2025
Merged

Fix port conflicts for shared listeners#849
anuruddhal merged 1 commit intoballerina-platform:masterfrom
anuruddhal:2201.12.x

Conversation

@anuruddhal
Copy link
Member

@anuruddhal anuruddhal requested a review from Copilot August 27, 2025 05:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses port conflicts for shared listeners by preventing duplicate service ports from being added to the service port list. The fix ensures that when multiple services share the same port, only one service port entry is created, avoiding conflicts in Kubernetes service definitions.

  • Adds duplicate port checking logic to prevent port conflicts
  • Implements early termination when a port is already defined in the service ports list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@anuruddhal anuruddhal merged commit 436af42 into ballerina-platform:master Aug 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants