Fix port conflicts for shared listeners#849
Merged
anuruddhal merged 1 commit intoballerina-platform:masterfrom Aug 27, 2025
Merged
Fix port conflicts for shared listeners#849anuruddhal merged 1 commit intoballerina-platform:masterfrom
anuruddhal merged 1 commit intoballerina-platform:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses port conflicts for shared listeners by preventing duplicate service ports from being added to the service port list. The fix ensures that when multiple services share the same port, only one service port entry is created, avoiding conflicts in Kubernetes service definitions.
- Adds duplicate port checking logic to prevent port conflicts
- Implements early termination when a port is already defined in the service ports list
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
compiler-plugin/src/main/java/io/ballerina/c2c/handlers/ServiceHandler.java
Show resolved
Hide resolved
tharindu-nw
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose