-
Notifications
You must be signed in to change notification settings - Fork 36
Initialize the compiler plugin for static code analysis #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,3 +37,5 @@ target | |
| # Ballerina | ||
| velocity.log* | ||
| *Ballerina.lock | ||
|
|
||
| compiler-plugin-tests/**/target | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| [plugin] | ||
| id = "crypto-compiler-plugin" | ||
| class = "io.ballerina.stdlib.crypto.compiler.CryptoCompilerPlugin" | ||
|
|
||
| [[dependency]] | ||
| path = "../compiler-plugin/build/libs/crypto-compiler-plugin-2.9.1-SNAPSHOT.jar" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| [plugin] | ||
| id = "crypto-compiler-plugin" | ||
| class = "io.ballerina.stdlib.crypto.compiler.CryptoCompilerPlugin" | ||
|
|
||
| [[dependency]] | ||
| path = "../compiler-plugin/build/libs/crypto-compiler-plugin-@project.version@.jar" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| /* | ||
| * Copyright (c) 2025, WSO2 LLC. (http://www.wso2.org) | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| plugins { | ||
| id 'java' | ||
| id 'checkstyle' | ||
| id 'com.github.spotbugs' | ||
| } | ||
|
|
||
| description = 'Ballerina - Crypto Compiler Plugin Tests' | ||
|
|
||
| dependencies { | ||
| checkstyle project(':checkstyle') | ||
| checkstyle "com.puppycrawl.tools:checkstyle:${checkstylePluginVersion}" | ||
|
|
||
| implementation project(':crypto-compiler-plugin') | ||
|
|
||
| testImplementation group: 'org.ballerinalang', name: 'ballerina-lang', version: "${ballerinaLangVersion}" | ||
| testImplementation group: 'org.ballerinalang', name: 'ballerina-tools-api', version: "${ballerinaLangVersion}" | ||
| testImplementation group: 'org.ballerinalang', name: 'ballerina-parser', version: "${ballerinaLangVersion}" | ||
|
|
||
| testImplementation group: 'org.testng', name: 'testng', version: "${testngVersion}" | ||
| } | ||
| tasks.withType(JavaCompile).configureEach { | ||
| options.encoding = 'UTF-8' | ||
| } | ||
|
|
||
| sourceCompatibility = JavaVersion.VERSION_21 | ||
|
|
||
| test { | ||
| systemProperty "ballerina.offline.flag", "true" | ||
| useTestNG() { | ||
| suites 'src/test/resources/testng.xml' | ||
| } | ||
| testLogging.showStandardStreams = true | ||
| testLogging { | ||
| events "PASSED", "FAILED", "SKIPPED" | ||
| afterSuite { desc, result -> | ||
| if (!desc.parent) { // will match the outermost suite | ||
| def output = "Results: ${result.resultType} (${result.testCount} tests, ${result.successfulTestCount} successes, ${result.failedTestCount} failures, ${result.skippedTestCount} skipped)" | ||
| def startItem = '| ', endItem = ' |' | ||
| def repeatLength = startItem.length() + output.length() + endItem.length() | ||
| println('\n' + ('-' * repeatLength) + '\n' + startItem + output + endItem + '\n' + ('-' * repeatLength)) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| spotbugsTest { | ||
| def classLoader = plugins["com.github.spotbugs"].class.classLoader | ||
| def SpotBugsConfidence = classLoader.findLoadedClass("com.github.spotbugs.snom.Confidence") | ||
| def SpotBugsEffort = classLoader.findLoadedClass("com.github.spotbugs.snom.Effort") | ||
| ignoreFailures = true | ||
| effort = SpotBugsEffort.MAX | ||
| reportLevel = SpotBugsConfidence.LOW | ||
| reportsDir = file("$project.buildDir/reports/spotbugs") | ||
| def excludeFile = file("${rootDir}/build-config/spotbugs-exclude.xml") | ||
| if (excludeFile.exists()) { | ||
| it.excludeFilter = excludeFile | ||
| } | ||
| reports { | ||
| text.enabled = true | ||
| } | ||
| } | ||
|
|
||
| spotbugsMain { | ||
| enabled false | ||
| } | ||
|
|
||
| tasks.register('validateSpotbugs') { | ||
| doLast { | ||
| if (spotbugsMain.reports.size() > 0 && | ||
| spotbugsMain.reports[0].destination.exists() && | ||
| spotbugsMain.reports[0].destination.text.readLines().size() > 0) { | ||
| spotbugsMain.reports[0].destination?.eachLine { | ||
| println 'Failure: ' + it | ||
| } | ||
| throw new GradleException("Spotbugs rule violations were found."); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| tasks.withType(Checkstyle).configureEach { | ||
| exclude '**/module-info.java' | ||
| } | ||
|
|
||
| checkstyle { | ||
| toolVersion "${project.checkstylePluginVersion}" | ||
| configFile rootProject.file("build-config/checkstyle/build/checkstyle.xml") | ||
| configProperties = ["suppressionFile": file("${rootDir}/build-config/checkstyle/build/suppressions.xml")] | ||
| } | ||
|
|
||
| checkstyleMain { | ||
| enabled false | ||
| } | ||
|
|
||
| spotbugsTest.finalizedBy validateSpotbugs | ||
| checkstyleTest.dependsOn ':checkstyle:downloadCheckstyleRuleFiles' | ||
|
|
||
| compileJava { | ||
| doFirst { | ||
| options.compilerArgs = [ | ||
| '--module-path', classpath.asPath, | ||
| ] | ||
| classpath = files() | ||
| } | ||
| } | ||
|
|
||
| test.dependsOn ":crypto-ballerina:build" | ||
| build.dependsOn ":crypto-ballerina:build" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| * Copyright (c) 2025 WSO2 LLC. (http://www.wso2.com). | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS | ||
| * OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| plugins { | ||
| id 'java' | ||
| id 'checkstyle' | ||
| id 'com.github.spotbugs' | ||
| } | ||
|
|
||
| description = 'Ballerina - Crypto Compiler Plugin' | ||
|
|
||
|
|
||
| dependencies { | ||
| checkstyle project(':checkstyle') | ||
| checkstyle "com.puppycrawl.tools:checkstyle:${checkstylePluginVersion}" | ||
|
|
||
| implementation group: 'org.ballerinalang', name: 'ballerina-lang', version: "${ballerinaLangVersion}" | ||
| implementation group: 'org.ballerinalang', name: 'ballerina-tools-api', version: "${ballerinaLangVersion}" | ||
| implementation group: 'org.ballerinalang', name: 'ballerina-parser', version: "${ballerinaLangVersion}" | ||
| implementation group: 'io.ballerina.scan', name: 'scan-command', version: "${balScanVersion}" | ||
| implementation project(":crypto-native") | ||
| } | ||
|
|
||
| def excludePattern = '**/module-info.java' | ||
| tasks.withType(Checkstyle).configureEach { | ||
| exclude excludePattern | ||
| } | ||
|
|
||
| checkstyle { | ||
| toolVersion "${project.checkstylePluginVersion}" | ||
| configFile rootProject.file("build-config/checkstyle/build/checkstyle.xml") | ||
| configProperties = ["suppressionFile": file("${rootDir}/build-config/checkstyle/build/suppressions.xml")] | ||
| } | ||
|
|
||
| checkstyleMain.dependsOn(":checkstyle:downloadCheckstyleRuleFiles") | ||
|
|
||
| spotbugsMain { | ||
| def classLoader = plugins["com.github.spotbugs"].class.classLoader | ||
| def SpotBugsConfidence = classLoader.findLoadedClass("com.github.spotbugs.snom.Confidence") | ||
| def SpotBugsEffort = classLoader.findLoadedClass("com.github.spotbugs.snom.Effort") | ||
| effort = SpotBugsEffort.MAX | ||
| reportLevel = SpotBugsConfidence.LOW | ||
| reportsDir = file("$project.buildDir/reports/spotbugs") | ||
| reports { | ||
| html.enabled true | ||
| text.enabled = true | ||
| } | ||
| def excludeFile = file("${rootDir}/spotbugs-exclude.xml") | ||
| if (excludeFile.exists()) { | ||
| excludeFilter = excludeFile | ||
| } | ||
| } | ||
|
|
||
| compileJava { | ||
| doFirst { | ||
| options.compilerArgs = [ | ||
| '--module-path', classpath.asPath, | ||
| ] | ||
| classpath = files() | ||
| } | ||
| } | ||
|
|
||
| build.dependsOn ":crypto-native:build" |
28 changes: 28 additions & 0 deletions
28
compiler-plugin/src/main/java/io/ballerina/stdlib/crypto/compiler/CryptoCompilerPlugin.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| * Copyright (c) 2025 WSO2 LLC. (http://www.wso2.com). | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS | ||
| * OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.ballerina.stdlib.crypto.compiler; | ||
|
|
||
| /** | ||
| * Crypto compiler plugin. | ||
| * | ||
| * @since 2.9.1 | ||
| */ | ||
| public class CryptoCompilerPlugin { | ||
|
|
||
| } | ||
23 changes: 23 additions & 0 deletions
23
...io/ballerina/stdlib/crypto/compiler/staticcodeanalyzer/CryptoCipherAlgorithmAnalyzer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright (c) 2025 WSO2 LLC. (http://www.wso2.com). | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS | ||
| * OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.ballerina.stdlib.crypto.compiler.staticcodeanalyzer; | ||
|
|
||
| public class CryptoCipherAlgorithmAnalyzer { | ||
|
|
||
nureka-rodrigo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
23 changes: 23 additions & 0 deletions
23
.../main/java/io/ballerina/stdlib/crypto/compiler/staticcodeanalyzer/CryptoCodeAnalyzer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright (c) 2025 WSO2 LLC. (http://www.wso2.com). | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS | ||
| * OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.ballerina.stdlib.crypto.compiler.staticcodeanalyzer; | ||
|
|
||
| public class CryptoCodeAnalyzer { | ||
|
|
||
nureka-rodrigo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
22 changes: 22 additions & 0 deletions
22
...ugin/src/main/java/io/ballerina/stdlib/crypto/compiler/staticcodeanalyzer/CryptoRule.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /* | ||
| * Copyright (c) 2025 WSO2 LLC. (http://www.wso2.com). | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS | ||
| * OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.ballerina.stdlib.crypto.compiler.staticcodeanalyzer; | ||
|
|
||
| public class CryptoRule { | ||
nureka-rodrigo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.