Skip to content

Comments

Fix unexpected error due to closed method not implemented in Ballerina stream object#609

Merged
TharmiganK merged 5 commits intomasterfrom
close-fix
Sep 29, 2025
Merged

Fix unexpected error due to closed method not implemented in Ballerina stream object#609
TharmiganK merged 5 commits intomasterfrom
close-fix

Conversation

@TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Sep 29, 2025

Purpose

$Subject

Fixes: ballerina-platform/ballerina-library#8288

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

ThisaruGuruge
ThisaruGuruge previously approved these changes Sep 29, 2025
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.72%. Comparing base (cd7bbcf) to head (5d66ea9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../ballerina/stdlib/crypto/BallerinaInputStream.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #609      +/-   ##
============================================
+ Coverage     82.62%   82.72%   +0.10%     
- Complexity      239      241       +2     
============================================
  Files            28       28              
  Lines          1335     1343       +8     
  Branches        182      183       +1     
============================================
+ Hits           1103     1111       +8     
+ Misses          186      185       -1     
- Partials         46       47       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TharmiganK TharmiganK merged commit 73b55b5 into master Sep 29, 2025
7 of 8 checks passed
@TharmiganK TharmiganK deleted the close-fix branch September 29, 2025 13:11
TharmiganK added a commit that referenced this pull request Oct 21, 2025
Fix unexpected error due to closed method not implemented in Ballerina stream object

(cherry picked from commit 73b55b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PGP encryption stream API attempts to call the close function even when the stream doesn’t have it

3 participants