Fix handling of segment groups#72
Merged
niveathika merged 2 commits intoballerina-platform:mainfrom Apr 8, 2025
Merged
Conversation
- checking the first segment to decide whether to traverse a segment group or not is not always correct. - there are segments that are optional. - we have to traverse through the segments of a group and find an appropriate match.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 71.18% 70.74% -0.45%
==========================================
Files 11 11
Lines 701 728 +27
Branches 256 267 +11
==========================================
+ Hits 499 515 +16
- Misses 202 213 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
niveathika
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose