Skip to content

Comments

Fix handling of segment groups#72

Merged
niveathika merged 2 commits intoballerina-platform:mainfrom
nirmal070125:x12-bug
Apr 8, 2025
Merged

Fix handling of segment groups#72
niveathika merged 2 commits intoballerina-platform:mainfrom
nirmal070125:x12-bug

Conversation

@nirmal070125
Copy link
Contributor

Purpose

  • checking the first segment to decide whether to traverse a segment group or not is not always correct.
  • there are segments that are optional.
  • we have to traverse through the segments of a group and find an appropriate match.

- checking the first segment to decide whether to traverse a segment group or not is not always correct.
- there are segments that are optional.
- we have to traverse through the segments of a group and find an appropriate match.
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.74%. Comparing base (3b5457e) to head (8940773).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ballerina/segment_group_reader.bal 87.87% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   71.18%   70.74%   -0.45%     
==========================================
  Files          11       11              
  Lines         701      728      +27     
  Branches      256      267      +11     
==========================================
+ Hits          499      515      +16     
- Misses        202      213      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@niveathika niveathika merged commit 64187f3 into ballerina-platform:main Apr 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants