Skip to content

Comments

Fix dependent loop in X12 278s#73

Merged
niveathika merged 2 commits intoballerina-platform:mainfrom
nirmal070125:x12-branch
May 2, 2025
Merged

Fix dependent loop in X12 278s#73
niveathika merged 2 commits intoballerina-platform:mainfrom
nirmal070125:x12-branch

Conversation

@nirmal070125
Copy link
Contributor

Purpose

  • X12 278 contains dependent info in a Loop 2000D.
  • But this loop should be present only when the HL segment has a code 23 for HL03__HierarchicalLevelCode element as per the X12 278-A3 spec.
  • We need to special case this and add a condition to get this fix into the edi module.
  • This should not break any other edi messagges, as the code make sures it applies only to X12 278.
  • Also the PR contains an improvement to a debug log.

- it makes it easier to debug
- X12 278 contains dependent info in a Loop 2000D.
- But this loop should be present only when the HL segment has a code 23 for HL03__HierarchicalLevelCode element as per the X12 278-A3 spec.
- We need to special case this and add a condition to get this fix into the edi module.
- This should not break any other edi messagges, as the code make sures it applies only to X12 278.
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.90%. Comparing base (64187f3) to head (7d2af57).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   70.74%   70.90%   +0.15%     
==========================================
  Files          11       11              
  Lines         728      732       +4     
  Branches      267      269       +2     
==========================================
+ Hits          515      519       +4     
  Misses        213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@niveathika niveathika merged commit edb00fb into ballerina-platform:main May 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants