Fix dependent loop in X12 278s#73
Merged
niveathika merged 2 commits intoballerina-platform:mainfrom May 2, 2025
Merged
Conversation
- it makes it easier to debug
- X12 278 contains dependent info in a Loop 2000D. - But this loop should be present only when the HL segment has a code 23 for HL03__HierarchicalLevelCode element as per the X12 278-A3 spec. - We need to special case this and add a condition to get this fix into the edi module. - This should not break any other edi messagges, as the code make sures it applies only to X12 278.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 70.74% 70.90% +0.15%
==========================================
Files 11 11
Lines 728 732 +4
Branches 267 269 +2
==========================================
+ Hits 515 519 +4
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RDPerera
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose