Skip to content

Fix missing error handling in file:copy for non-existent destination directory #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niveathika merged 2 commits into from
Oct 7, 2025
Merged

Fix missing error handling in file:copy for non-existent destination directory #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5061dd7
Handle target directory not found error
DharshiBalasubramaniyam Oct 3, 2025
58d34be
Remove unnecessary log lines
DharshiBalasubramaniyam Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ballerina/tests/file-test.bal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,17 @@ function testCopyFileNonExistSource() {
}
}

@test:Config {}
function testCopyFileNonExistDir() {
error? copyResult = copy(srcFile, noDir + copyFile);
if copyResult is error {
string expectedErrMsg = "The target directory does not exist";
test:assertTrue(copyResult.message().includes(expectedErrMsg));
} else {
test:assertFail("File copy succeeded to a non-existent destination directory!");
}
}

@test:Config {}
function testGetCurrentDirectory() {
string currentDir = getCurrentDir();
Expand Down
2 changes: 2 additions & 0 deletions native/src/main/java/io/ballerina/stdlib/file/nativeimpl/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,8 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IO
Path newFile = target.resolve(source.relativize(file));
try {
Files.copy(file, newFile, copyOptions);
} catch (NoSuchFileException e) {
throw e;
} catch (Exception e) {
log.debug(e.getMessage());
return SKIP_SUBTREE; // skip processing
Expand Down