Make listener configuration as an included parameter #1421
Merged
TharmiganK merged 6 commits intomasterfrom Jan 28, 2025
Merged
Make listener configuration as an included parameter #1421TharmiganK merged 6 commits intomasterfrom
TharmiganK merged 6 commits intomasterfrom
Conversation
TharmiganK
requested review from
DimuthuMadushan,
MohamedSabthar,
ThisaruGuruge and
shafreenAnfar
as code owners
TharmiganK
force-pushed
the
listener-config
branch
from
bb0abac to
116b3de
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
============================================
- Coverage 84.47% 83.29% -1.18%
- Complexity 244 341 +97
============================================
Files 28 37 +9
Lines 1288 1634 +346
Branches 157 239 +82
============================================
+ Hits 1088 1361 +273
- Misses 140 172 +32
- Partials 60 101 +41 ☔ View full report in Codecov by Sentry. |
ThisaruGuruge
approved these changes
Jan 28, 2025
Member
|
@TharmiganK don't we have to bump the minor version ? |
Contributor
Author
Thinking of adding this with Update 11 and the minor version is already bumped for Update 11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Part of: ballerina-platform/ballerina-library#7494
Examples
N/A
Checklist
Checked native-image compatibility