Add userDirIsRoot configuration to FTP/SFTP client to support jailed home directories#1487
Conversation
native/src/main/java/io/ballerina/stdlib/ftp/client/FtpClient.java
Outdated
Show resolved
Hide resolved
|
@SachinAkash01 lets create a Ballerina library issue for this and tag here in the PR. Along with that lets update the changelog + package spec. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1487 +/- ##
============================================
- Coverage 84.72% 83.57% -1.15%
- Complexity 241 338 +97
============================================
Files 28 37 +9
Lines 1283 1632 +349
Branches 156 237 +81
============================================
+ Hits 1087 1364 +277
- Misses 133 165 +32
- Partials 63 103 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@SachinAkash01 better if we could update the |
@ayeshLK Created a Ballerina Library issue and linked it. For the documentation and test cases, I'm planning to send another PR. |
native/src/main/java/io/ballerina/stdlib/ftp/client/FtpClient.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/ftp/transport/server/util/FileTransportUtils.java
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/ftp/transport/server/util/FileTransportUtils.java
Show resolved
Hide resolved
The usual practice is to have the test cases and documentation(spec and change log) in the same PR. Thats why we have the check list in the description. |
This fix was required urgently.. So that's why we were planning to do a quick release. But since they have went ahead with a workaround, I will update the PR today. |
|



Purpose
Fixes: ballerina-platform/ballerina-library#8153
Examples
For an example, after new config flag to set userDirIsRoot explicitly:
Checklist