Fix connection failure for sftp with only username#1500
Merged
niveathika merged 4 commits intoballerina-platform:masterfrom Oct 30, 2025
Merged
Fix connection failure for sftp with only username#1500niveathika merged 4 commits intoballerina-platform:masterfrom
niveathika merged 4 commits intoballerina-platform:masterfrom
Conversation
niveathika
requested review from
DimuthuMadushan,
MohamedSabthar,
ThisaruGuruge and
shafreenAnfar
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1500 +/- ##
============================================
- Coverage 84.86% 83.52% -1.34%
- Complexity 244 345 +101
============================================
Files 28 37 +9
Lines 1295 1651 +356
Branches 156 244 +88
============================================
+ Hits 1099 1379 +280
- Misses 133 166 +33
- Partials 63 106 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes SFTP connection failures when only a username is provided without a password, addressing authentication handling for key-based SFTP connections.
Key Changes
- Modified password field in
Credentialsrecord to be optional - Updated password handling logic to support null values for SFTP protocol
- Added protocol parameter to
getAuthMapmethod for protocol-specific authentication handling
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| native/src/main/java/io/ballerina/stdlib/ftp/util/FtpUtil.java | Enhanced password handling to support null values for SFTP and added protocol-aware authentication |
| native/src/main/java/io/ballerina/stdlib/ftp/client/FtpClient.java | Updated method call to pass protocol parameter for authentication mapping |
| ballerina/commons.bal | Changed password field to optional in Credentials record |
| gradle.properties | Bumped version to 2.15.0-SNAPSHOT |
| ballerina/Dependencies.toml | Updated package version to 2.15.0 |
| ballerina/CompilerPlugin.toml | Updated compiler plugin JAR path to 2.15.0-SNAPSHOT |
| ballerina/Ballerina.toml | Updated package and native library versions to 2.15.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
niveathika
added
the
Skip GraalVM Check
daneshk
reviewed
Oct 23, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes wso2/product-ballerina-integrator#674
Fixes wso2/product-ballerina-integrator#675
Fixes ballerina-platform/ballerina-library#8155
Examples
Checklist