Skip to content

Comments

Add streaming put methods#1507

Merged
niveathika merged 15 commits intoballerina-platform:masterfrom
niveathika:master
Nov 7, 2025
Merged

Add streaming put methods#1507
niveathika merged 15 commits intoballerina-platform:masterfrom
niveathika:master

Conversation

@niveathika
Copy link
Contributor

Purpose

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@niveathika niveathika added the Skip GraalVM Check This will skip the GraalVM compatibility check label Nov 6, 2025
@niveathika niveathika requested a review from Copilot November 6, 2025 05:27

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 77.48344% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.42%. Comparing base (9dcac50) to head (26ff1d5).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...rina/stdlib/ftp/ContentCsvStreamIteratorUtils.java 61.19% 18 Missing and 8 partials ⚠️
...java/io/ballerina/stdlib/ftp/client/FtpClient.java 80.00% 16 Missing and 4 partials ⚠️
...in/java/io/ballerina/stdlib/ftp/util/CSVUtils.java 81.66% 4 Missing and 7 partials ⚠️
...o/ballerina/stdlib/ftp/client/FtpClientHelper.java 76.19% 5 Missing ⚠️
ballerina/content_csv_record_stream.bal 88.23% 2 Missing ⚠️
ballerina/content_csv_string_stream.bal 88.23% 2 Missing ⚠️
...ina/stdlib/ftp/ContentByteStreamIteratorUtils.java 33.33% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (68.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1507      +/-   ##
============================================
- Coverage     68.54%   68.42%   -0.12%     
- Complexity      292      445     +153     
============================================
  Files            34       49      +15     
  Lines          1860     2667     +807     
  Branches        245      414     +169     
============================================
+ Hits           1275     1825     +550     
- Misses          495      685     +190     
- Partials         90      157      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

native/src/main/java/io/ballerina/stdlib/ftp/client/FtpClient.java:1

  • The previous code had a ternary operator checking content is json which is now removed. While the new implementation is simpler, ensure that both json and record {} types have a toJsonString() method to avoid potential runtime errors.
/*

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@niveathika niveathika merged commit 4638ed7 into ballerina-platform:master Nov 7, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip GraalVM Check This will skip the GraalVM compatibility check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants