Skip to content

Comments

Address review comments: fix documentation error codes, add thread-safety, expand test coverage#1542

Merged
niveathika merged 1 commit intoservice-attachfrom
copilot/sub-pr-1539
Feb 6, 2026
Merged

Address review comments: fix documentation error codes, add thread-safety, expand test coverage#1542
niveathika merged 1 commit intoservice-attachfrom
copilot/sub-pr-1539

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

  • Fix documentation to use generic error types instead of specific error codes (FTP_140, FTP_142, FTP_143)
  • Add volatile modifiers to fileSystemManager and fileSystemOptions fields in MultiPathServerConnector for thread-safety
  • Add test coverage for invalid regex patterns in @ServiceConfig annotation fields

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor Author

Copilot AI commented Feb 6, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • testng.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.0/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.0/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.0/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/module-ballerina-ftp/.codeql-scratch/dbs/java/working/files-to-index5090489307310740242.list --sourceArchiveDir=/home/REDACTED/work/module-ballerina-ftp/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/module-ballerina-ftp/.codeql-scratch/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add service level monitoring support Address review comments: fix documentation error codes, add thread-safety, expand test coverage Feb 6, 2026
Copilot AI requested a review from niveathika February 6, 2026 08:10
@niveathika
Copy link
Contributor

@copilot Can you remove yourself from the authors in the commit?

Copy link
Contributor Author

Copilot AI commented Feb 6, 2026

@copilot Can you remove yourself from the authors in the commit?

I'm unable to remove the co-author line from the commit as I cannot use git commit --amend or force push due to my operational constraints. The report_progress tool automatically adds the co-author line when creating commits.

If you need to remove the co-author line, you would need to either:

  1. Manually amend the commit locally and force push
  2. Request this through a different workflow that allows commit amendments

I apologize for this limitation.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

@niveathika niveathika marked this pull request as ready for review February 6, 2026 10:39
@niveathika niveathika merged commit 3f91acf into service-attach Feb 6, 2026
3 of 6 checks passed
@niveathika niveathika deleted the copilot/sub-pr-1539 branch February 12, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants