Skip to content

Fix FTP/SFTP listener not triggering when fileNamePattern is not specified #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niveathika merged 2 commits into from
Feb 16, 2026
Merged

Fix FTP/SFTP listener not triggering when fileNamePattern is not specified #1548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4c1328
Fix FTP/SFTP listener not triggering when fileNamePattern is not spec…
niveathika Feb 13, 2026
c001ac3
Merge branch 'master' into fix-optional-filenamepattern
niveathika Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- [Incorporate the csv fail safe support in the FTP listener](https://github.com/ballerina-platform/ballerina-library/issues/8502)

### Fixed

- [Fix FTP/SFTP listener not triggering when fileNamePattern is not specified](https://github.com/wso2/product-ballerina-integrator/issues/656)
- [Fix Listener silently fails when errors occur](https://github.com/ballerina-platform/ballerina-library/issues/8655)

## [2.16.0] - 2025-12-19
Expand Down
11 changes: 6 additions & 5 deletions native/src/main/java/io/ballerina/stdlib/ftp/server/FtpListenerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,14 +778,15 @@ private static List<FileDependencyCondition> parseFileDependencyConditions(
return conditions;
}

private static void addStringProperty(BMap config, Map<String, Object> params)
private static void addStringProperty(BMap config, Map<String, Object> params)
throws FtpInvalidConfigException {
BString namePatternString = config.getStringValue(StringUtils.fromString(
FtpConstants.ENDPOINT_CONFIG_FILE_PATTERN));
String fileNamePattern = (namePatternString != null && !namePatternString.getValue().isEmpty()) ?
namePatternString.getValue() : "";
FtpUtil.validateRegexPattern(fileNamePattern, "fileNamePattern");
params.put(FtpConstants.FILE_NAME_PATTERN, fileNamePattern);
if (namePatternString != null && !namePatternString.getValue().isEmpty()) {
String fileNamePattern = namePatternString.getValue();
FtpUtil.validateRegexPattern(fileNamePattern, "fileNamePattern");
params.put(FtpConstants.FILE_NAME_PATTERN, fileNamePattern);
}
}

public static Object poll(BObject ftpListener) {
Expand Down
10 changes: 5 additions & 5 deletions native/src/main/java/io/ballerina/stdlib/ftp/transport/server/RemoteFileSystemConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ private void closeDirectories() {
*/
private void handleDirectory(FileObject[] children) throws FileSystemException {
for (FileObject child : children) {
if (!(fileNamePattern == null || child.getName().getBaseName().matches(fileNamePattern))) {
logDebugDirFileNamePatternNotMatchedInDirHandler();
if (fileNamePattern != null && !child.getName().getBaseName().matches(fileNamePattern)) {
logDebugFileNamePatternNotMatched(child);
} else {
FileType childType = child.getType();
if (childType == FileType.FOLDER) {
Expand Down Expand Up @@ -512,10 +512,10 @@ private void logDebugNoChildrenFromDirWhileConsuming() {
}

@ExcludeCoverageFromGeneratedReport
private void logDebugDirFileNamePatternNotMatchedInDirHandler() {
private void logDebugFileNamePatternNotMatched(FileObject file) {
if (log.isDebugEnabled()) {
log.debug("File " + listeningDir.getName().getFriendlyURI()
+ " is not processed because it did not match the specified pattern.");
log.debug(file.getName().getFriendlyURI()
+ " is not processed because it did not match the specified pattern: " + fileNamePattern);
}
}

Expand Down
Loading